Skip to content

[Major] major refactoring of collectors #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vmoens wants to merge 25 commits into
base: main
Choose a base branch
from
Open

[Major] major refactoring of collectors #3233

vmoens wants to merge 25 commits into from
+12,296 −8,788

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Nov 7, 2025

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3233

Note: Links to docs will display an error until the docs builds have been completed.

❌ 15 New Failures, 7 Unrelated Failures

As of commit 512a5ed with merge base 8570c25 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 154. Improved: $\large\color{#35bf28}17$. Worsened: $\large\color{#d91a1a}8$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 82.1904μs 81.1074μs 12.3293 KOps/s 12.1490 KOps/s $\color{#35bf28}+1.48\%$
test_tensor_to_bytestream_speed[torch.save] 0.1471ms 0.1420ms 7.0420 KOps/s 7.0687 KOps/s $\color{#d91a1a}-0.38\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1242s 0.1242s 8.0531 Ops/s 7.9879 Ops/s $\color{#35bf28}+0.82\%$
test_tensor_to_bytestream_speed[numpy] 3.1104μs 3.0895μs 323.6797 KOps/s 326.3975 KOps/s $\color{#d91a1a}-0.83\%$
test_tensor_to_bytestream_speed[safetensors] 41.6967μs 41.4070μs 24.1505 KOps/s 24.3399 KOps/s $\color{#d91a1a}-0.78\%$
test_simple 0.6736s 0.5767s 1.7340 Ops/s 1.7965 Ops/s $\color{#d91a1a}-3.48\%$
test_transformed 1.2304s 1.1325s 0.8830 Ops/s 0.8977 Ops/s $\color{#d91a1a}-1.63\%$
test_serial 1.6900s 1.6864s 0.5930 Ops/s 0.5913 Ops/s $\color{#35bf28}+0.28\%$
test_parallel 1.2039s 1.1163s 0.8958 Ops/s 0.8754 Ops/s $\color{#35bf28}+2.34\%$
test_step_mdp_speed[True-True-True-True-True] 0.1659ms 44.4702μs 22.4870 KOps/s 21.9980 KOps/s $\color{#35bf28}+2.22\%$
test_step_mdp_speed[True-True-True-True-False] 0.4312ms 24.9645μs 40.0569 KOps/s 40.2637 KOps/s $\color{#d91a1a}-0.51\%$
test_step_mdp_speed[True-True-True-False-True] 0.4404ms 25.2545μs 39.5969 KOps/s 39.0248 KOps/s $\color{#35bf28}+1.47\%$
test_step_mdp_speed[True-True-True-False-False] 52.0910μs 13.9388μs 71.7422 KOps/s 70.6642 KOps/s $\color{#35bf28}+1.53\%$
test_step_mdp_speed[True-True-False-True-True] 0.4610ms 47.7916μs 20.9242 KOps/s 20.6491 KOps/s $\color{#35bf28}+1.33\%$
test_step_mdp_speed[True-True-False-True-False] 66.1410μs 28.3961μs 35.2161 KOps/s 34.9182 KOps/s $\color{#35bf28}+0.85\%$
test_step_mdp_speed[True-True-False-False-True] 0.4428ms 28.3363μs 35.2905 KOps/s 34.8608 KOps/s $\color{#35bf28}+1.23\%$
test_step_mdp_speed[True-True-False-False-False] 52.7910μs 16.9644μs 58.9468 KOps/s 58.2806 KOps/s $\color{#35bf28}+1.14\%$
test_step_mdp_speed[True-False-True-True-True] 0.4650ms 51.8778μs 19.2761 KOps/s 19.2176 KOps/s $\color{#35bf28}+0.30\%$
test_step_mdp_speed[True-False-True-True-False] 0.4431ms 31.4349μs 31.8118 KOps/s 31.9070 KOps/s $\color{#d91a1a}-0.30\%$
test_step_mdp_speed[True-False-True-False-True] 0.4419ms 28.7732μs 34.7546 KOps/s 34.5728 KOps/s $\color{#35bf28}+0.53\%$
test_step_mdp_speed[True-False-True-False-False] 63.8710μs 16.6811μs 59.9482 KOps/s 59.1884 KOps/s $\color{#35bf28}+1.28\%$
test_step_mdp_speed[True-False-False-True-True] 0.4741ms 53.1218μs 18.8247 KOps/s 18.5301 KOps/s $\color{#35bf28}+1.59\%$
test_step_mdp_speed[True-False-False-True-False] 0.4464ms 33.6257μs 29.7392 KOps/s 29.2587 KOps/s $\color{#35bf28}+1.64\%$
test_step_mdp_speed[True-False-False-False-True] 0.4400ms 30.4593μs 32.8307 KOps/s 32.0993 KOps/s $\color{#35bf28}+2.28\%$
test_step_mdp_speed[True-False-False-False-False] 53.3310μs 19.3799μs 51.5999 KOps/s 50.8625 KOps/s $\color{#35bf28}+1.45\%$
test_step_mdp_speed[False-True-True-True-True] 0.4761ms 50.6351μs 19.7492 KOps/s 19.4080 KOps/s $\color{#35bf28}+1.76\%$
test_step_mdp_speed[False-True-True-True-False] 0.4445ms 31.3057μs 31.9430 KOps/s 31.9921 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[False-True-True-False-True] 2.4785ms 32.2281μs 31.0288 KOps/s 30.8037 KOps/s $\color{#35bf28}+0.73\%$
test_step_mdp_speed[False-True-True-False-False] 50.6610μs 18.8200μs 53.1349 KOps/s 52.9620 KOps/s $\color{#35bf28}+0.33\%$
test_step_mdp_speed[False-True-False-True-True] 86.9310μs 53.4253μs 18.7177 KOps/s 18.3918 KOps/s $\color{#35bf28}+1.77\%$
test_step_mdp_speed[False-True-False-True-False] 0.4446ms 33.6072μs 29.7555 KOps/s 29.1818 KOps/s $\color{#35bf28}+1.97\%$
test_step_mdp_speed[False-True-False-False-True] 0.4444ms 34.6464μs 28.8630 KOps/s 28.8880 KOps/s $\color{#d91a1a}-0.09\%$
test_step_mdp_speed[False-True-False-False-False] 0.4337ms 21.3593μs 46.8180 KOps/s 46.6272 KOps/s $\color{#35bf28}+0.41\%$
test_step_mdp_speed[False-False-True-True-True] 91.8110μs 57.0080μs 17.5414 KOps/s 17.6364 KOps/s $\color{#d91a1a}-0.54\%$
test_step_mdp_speed[False-False-True-True-False] 0.4492ms 36.9849μs 27.0380 KOps/s 27.0847 KOps/s $\color{#d91a1a}-0.17\%$
test_step_mdp_speed[False-False-True-False-True] 0.4487ms 34.7503μs 28.7767 KOps/s 28.6687 KOps/s $\color{#35bf28}+0.38\%$
test_step_mdp_speed[False-False-True-False-False] 0.4263ms 21.3855μs 46.7607 KOps/s 46.8033 KOps/s $\color{#d91a1a}-0.09\%$
test_step_mdp_speed[False-False-False-True-True] 95.0710μs 57.9886μs 17.2448 KOps/s 16.9390 KOps/s $\color{#35bf28}+1.81\%$
test_step_mdp_speed[False-False-False-True-False] 0.4426ms 38.6552μs 25.8697 KOps/s 25.0473 KOps/s $\color{#35bf28}+3.28\%$
test_step_mdp_speed[False-False-False-False-True] 0.4476ms 36.9920μs 27.0329 KOps/s 27.3210 KOps/s $\color{#d91a1a}-1.05\%$
test_step_mdp_speed[False-False-False-False-False] 0.4288ms 23.6916μs 42.2091 KOps/s 42.1924 KOps/s $\color{#35bf28}+0.04\%$
test_values[generalized_advantage_estimate-True-True] 11.7348ms 11.3557ms 88.0611 Ops/s 89.2006 Ops/s $\color{#d91a1a}-1.28\%$
test_values[vec_generalized_advantage_estimate-True-True] 18.5131ms 11.5726ms 86.4107 Ops/s 89.0151 Ops/s $\color{#d91a1a}-2.93\%$
test_values[td0_return_estimate-False-False] 0.2499ms 0.1333ms 7.5034 KOps/s 7.4724 KOps/s $\color{#35bf28}+0.42\%$
test_values[td1_return_estimate-False-False] 30.5449ms 29.9909ms 33.3434 Ops/s 33.3483 Ops/s $\color{#d91a1a}-0.01\%$
test_values[vec_td1_return_estimate-False-False] 18.1881ms 11.6597ms 85.7656 Ops/s 87.2640 Ops/s $\color{#d91a1a}-1.72\%$
test_values[td_lambda_return_estimate-True-False] 46.2820ms 44.6024ms 22.4203 Ops/s 22.0737 Ops/s $\color{#35bf28}+1.57\%$
test_values[vec_td_lambda_return_estimate-True-False] 18.0897ms 11.7063ms 85.4238 Ops/s 87.2333 Ops/s $\color{#d91a1a}-2.07\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 10.0353ms 9.8950ms 101.0611 Ops/s 100.8043 Ops/s $\color{#35bf28}+0.25\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.6989ms 1.5262ms 655.2393 Ops/s 620.4820 Ops/s $\textbf{\color{#35bf28}+5.60\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.8463ms 0.4304ms 2.3233 KOps/s 2.2699 KOps/s $\color{#35bf28}+2.35\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 31.2502ms 30.2716ms 33.0343 Ops/s 33.4884 Ops/s $\color{#d91a1a}-1.36\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 2.1043ms 1.7939ms 557.4512 Ops/s 565.1861 Ops/s $\color{#d91a1a}-1.37\%$
test_dqn_speed[False-None] 7.1718ms 1.4453ms 691.8879 Ops/s 679.7984 Ops/s $\color{#35bf28}+1.78\%$
test_dqn_speed[False-backward] 2.0145ms 1.9636ms 509.2738 Ops/s 502.9315 Ops/s $\color{#35bf28}+1.26\%$
test_dqn_speed[True-None] 1.2136ms 0.5812ms 1.7206 KOps/s 1.6959 KOps/s $\color{#35bf28}+1.45\%$
test_dqn_speed[True-backward] 1.1442ms 1.0822ms 924.0120 Ops/s 775.7978 Ops/s $\textbf{\color{#35bf28}+19.10\%}$
test_dqn_speed[reduce-overhead-None] 0.6790ms 0.5587ms 1.7898 KOps/s 1.7265 KOps/s $\color{#35bf28}+3.67\%$
test_dqn_speed[reduce-overhead-backward] 1.1130ms 1.0568ms 946.2128 Ops/s 908.0994 Ops/s $\color{#35bf28}+4.20\%$
test_ddpg_speed[False-None] 3.3995ms 2.9401ms 340.1242 Ops/s 338.0036 Ops/s $\color{#35bf28}+0.63\%$
test_ddpg_speed[False-backward] 4.3549ms 4.2059ms 237.7588 Ops/s 238.0154 Ops/s $\color{#d91a1a}-0.11\%$
test_ddpg_speed[True-None] 1.8707ms 1.4623ms 683.8591 Ops/s 661.6196 Ops/s $\color{#35bf28}+3.36\%$
test_ddpg_speed[True-backward] 2.5762ms 2.5131ms 397.9073 Ops/s 388.9610 Ops/s $\color{#35bf28}+2.30\%$
test_ddpg_speed[reduce-overhead-None] 1.8664ms 1.4509ms 689.2255 Ops/s 665.5640 Ops/s $\color{#35bf28}+3.56\%$
test_ddpg_speed[reduce-overhead-backward] 2.5905ms 2.5050ms 399.2017 Ops/s 389.8801 Ops/s $\color{#35bf28}+2.39\%$
test_sac_speed[False-None] 8.6042ms 8.0368ms 124.4282 Ops/s 124.7061 Ops/s $\color{#d91a1a}-0.22\%$
test_sac_speed[False-backward] 11.7403ms 11.4400ms 87.4123 Ops/s 88.0291 Ops/s $\color{#d91a1a}-0.70\%$
test_sac_speed[True-None] 2.6513ms 2.2278ms 448.8651 Ops/s 447.8557 Ops/s $\color{#35bf28}+0.23\%$
test_sac_speed[True-backward] 4.3634ms 4.2520ms 235.1831 Ops/s 206.7508 Ops/s $\textbf{\color{#35bf28}+13.75\%}$
test_sac_speed[reduce-overhead-None] 2.3359ms 2.2029ms 453.9532 Ops/s 439.5744 Ops/s $\color{#35bf28}+3.27\%$
test_sac_speed[reduce-overhead-backward] 4.3893ms 4.2527ms 235.1421 Ops/s 215.1350 Ops/s $\textbf{\color{#35bf28}+9.30\%}$
test_redq_speed[False-None] 11.4844ms 10.7063ms 93.4026 Ops/s 92.8807 Ops/s $\color{#35bf28}+0.56\%$
test_redq_speed[False-backward] 19.7718ms 18.8586ms 53.0261 Ops/s 53.5271 Ops/s $\color{#d91a1a}-0.94\%$
test_redq_speed[True-None] 4.7558ms 4.5020ms 222.1249 Ops/s 219.5028 Ops/s $\color{#35bf28}+1.19\%$
test_redq_speed[True-backward] 10.8668ms 10.4468ms 95.7234 Ops/s 92.3503 Ops/s $\color{#35bf28}+3.65\%$
test_redq_speed[reduce-overhead-None] 4.9477ms 4.5201ms 221.2322 Ops/s 213.0789 Ops/s $\color{#35bf28}+3.83\%$
test_redq_speed[reduce-overhead-backward] 11.0798ms 10.5823ms 94.4970 Ops/s 97.5018 Ops/s $\color{#d91a1a}-3.08\%$
test_redq_deprec_speed[False-None] 11.7776ms 11.2362ms 88.9984 Ops/s 88.6233 Ops/s $\color{#35bf28}+0.42\%$
test_redq_deprec_speed[False-backward] 16.8149ms 16.3361ms 61.2140 Ops/s 60.6677 Ops/s $\color{#35bf28}+0.90\%$
test_redq_deprec_speed[True-None] 4.0976ms 3.7751ms 264.8957 Ops/s 258.8754 Ops/s $\color{#35bf28}+2.33\%$
test_redq_deprec_speed[True-backward] 8.7396ms 7.9369ms 125.9932 Ops/s 125.3663 Ops/s $\color{#35bf28}+0.50\%$
test_redq_deprec_speed[reduce-overhead-None] 4.1590ms 3.7642ms 265.6594 Ops/s 268.6200 Ops/s $\color{#d91a1a}-1.10\%$
test_redq_deprec_speed[reduce-overhead-backward] 8.2305ms 7.8819ms 126.8734 Ops/s 125.9397 Ops/s $\color{#35bf28}+0.74\%$
test_td3_speed[False-None] 8.2301ms 8.0698ms 123.9190 Ops/s 121.9673 Ops/s $\color{#35bf28}+1.60\%$
test_td3_speed[False-backward] 11.5785ms 11.1328ms 89.8246 Ops/s 89.9319 Ops/s $\color{#d91a1a}-0.12\%$
test_td3_speed[True-None] 1.9770ms 1.9107ms 523.3765 Ops/s 514.7134 Ops/s $\color{#35bf28}+1.68\%$
test_td3_speed[True-backward] 3.9931ms 3.8783ms 257.8480 Ops/s 213.0855 Ops/s $\textbf{\color{#35bf28}+21.01\%}$
test_td3_speed[reduce-overhead-None] 2.0655ms 1.8962ms 527.3719 Ops/s 522.0201 Ops/s $\color{#35bf28}+1.03\%$
test_td3_speed[reduce-overhead-backward] 4.0868ms 3.8865ms 257.2980 Ops/s 253.8666 Ops/s $\color{#35bf28}+1.35\%$
test_cql_speed[False-None] 30.0431ms 26.8660ms 37.2217 Ops/s 37.5563 Ops/s $\color{#d91a1a}-0.89\%$
test_cql_speed[False-backward] 40.7750ms 37.3401ms 26.7809 Ops/s 27.4485 Ops/s $\color{#d91a1a}-2.43\%$
test_cql_speed[True-None] 16.2175ms 13.2144ms 75.6753 Ops/s 77.5121 Ops/s $\color{#d91a1a}-2.37\%$
test_cql_speed[True-backward] 19.6376ms 18.9290ms 52.8289 Ops/s 52.2882 Ops/s $\color{#35bf28}+1.03\%$
test_cql_speed[reduce-overhead-None] 13.3420ms 12.9328ms 77.3226 Ops/s 76.4793 Ops/s $\color{#35bf28}+1.10\%$
test_cql_speed[reduce-overhead-backward] 19.6818ms 19.2277ms 52.0084 Ops/s 52.3031 Ops/s $\color{#d91a1a}-0.56\%$
test_a2c_speed[False-None] 5.8992ms 5.5569ms 179.9563 Ops/s 179.2463 Ops/s $\color{#35bf28}+0.40\%$
test_a2c_speed[False-backward] 12.6857ms 12.3384ms 81.0476 Ops/s 81.0306 Ops/s $\color{#35bf28}+0.02\%$
test_a2c_speed[True-None] 4.7598ms 3.9241ms 254.8341 Ops/s 253.7679 Ops/s $\color{#35bf28}+0.42\%$
test_a2c_speed[True-backward] 9.1896ms 8.9148ms 112.1728 Ops/s 106.8087 Ops/s $\textbf{\color{#35bf28}+5.02\%}$
test_a2c_speed[reduce-overhead-None] 4.3392ms 3.8834ms 257.5037 Ops/s 258.4904 Ops/s $\color{#d91a1a}-0.38\%$
test_a2c_speed[reduce-overhead-backward] 9.4221ms 9.2089ms 108.5907 Ops/s 107.4725 Ops/s $\color{#35bf28}+1.04\%$
test_ppo_speed[False-None] 6.3201ms 6.0169ms 166.1990 Ops/s 170.2485 Ops/s $\color{#d91a1a}-2.38\%$
test_ppo_speed[False-backward] 13.1628ms 12.8775ms 77.6551 Ops/s 78.4247 Ops/s $\color{#d91a1a}-0.98\%$
test_ppo_speed[True-None] 4.2138ms 3.7481ms 266.8019 Ops/s 264.7405 Ops/s $\color{#35bf28}+0.78\%$
test_ppo_speed[True-backward] 9.2265ms 8.8049ms 113.5734 Ops/s 110.8570 Ops/s $\color{#35bf28}+2.45\%$
test_ppo_speed[reduce-overhead-None] 4.2464ms 3.7715ms 265.1482 Ops/s 262.2253 Ops/s $\color{#35bf28}+1.11\%$
test_ppo_speed[reduce-overhead-backward] 9.6246ms 9.1844ms 108.8806 Ops/s 89.3001 Ops/s $\textbf{\color{#35bf28}+21.93\%}$
test_reinforce_speed[False-None] 5.2263ms 4.7172ms 211.9898 Ops/s 208.9685 Ops/s $\color{#35bf28}+1.45\%$
test_reinforce_speed[False-backward] 7.9713ms 7.6844ms 130.1345 Ops/s 128.5998 Ops/s $\color{#35bf28}+1.19\%$
test_reinforce_speed[True-None] 3.6121ms 3.0020ms 333.1137 Ops/s 330.6765 Ops/s $\color{#35bf28}+0.74\%$
test_reinforce_speed[True-backward] 8.4335ms 7.9186ms 126.2846 Ops/s 124.1092 Ops/s $\color{#35bf28}+1.75\%$
test_reinforce_speed[reduce-overhead-None] 3.4719ms 2.9893ms 334.5268 Ops/s 324.4410 Ops/s $\color{#35bf28}+3.11\%$
test_reinforce_speed[reduce-overhead-backward] 8.5784ms 8.2034ms 121.9002 Ops/s 113.7811 Ops/s $\textbf{\color{#35bf28}+7.14\%}$
test_iql_speed[False-None] 26.2252ms 21.0960ms 47.4023 Ops/s 47.9461 Ops/s $\color{#d91a1a}-1.13\%$
test_iql_speed[False-backward] 37.9637ms 31.9452ms 31.3036 Ops/s 31.4772 Ops/s $\color{#d91a1a}-0.55\%$
test_iql_speed[True-None] 9.2395ms 8.8595ms 112.8735 Ops/s 113.8508 Ops/s $\color{#d91a1a}-0.86\%$
test_iql_speed[True-backward] 17.9720ms 17.5810ms 56.8796 Ops/s 61.2557 Ops/s $\textbf{\color{#d91a1a}-7.14\%}$
test_iql_speed[reduce-overhead-None] 9.4484ms 8.9501ms 111.7307 Ops/s 115.8575 Ops/s $\color{#d91a1a}-3.56\%$
test_iql_speed[reduce-overhead-backward] 18.4686ms 17.9346ms 55.7582 Ops/s 55.8952 Ops/s $\color{#d91a1a}-0.25\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.6674ms 6.1831ms 161.7319 Ops/s 162.8002 Ops/s $\color{#d91a1a}-0.66\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0731ms 0.3400ms 2.9415 KOps/s 2.8174 KOps/s $\color{#35bf28}+4.40\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5767ms 0.2888ms 3.4623 KOps/s 2.8268 KOps/s $\textbf{\color{#35bf28}+22.48\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.5000ms 5.9348ms 168.4977 Ops/s 170.2532 Ops/s $\color{#d91a1a}-1.03\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7084ms 0.3060ms 3.2679 KOps/s 2.7081 KOps/s $\textbf{\color{#35bf28}+20.67\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.9378ms 0.3511ms 2.8484 KOps/s 2.6867 KOps/s $\textbf{\color{#35bf28}+6.02\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.7732ms 1.3593ms 735.6615 Ops/s 674.5551 Ops/s $\textbf{\color{#35bf28}+9.06\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.4917ms 1.2880ms 776.3730 Ops/s 698.1679 Ops/s $\textbf{\color{#35bf28}+11.20\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.2496ms 6.1012ms 163.9025 Ops/s 164.2827 Ops/s $\color{#d91a1a}-0.23\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0093ms 0.5394ms 1.8539 KOps/s 1.8974 KOps/s $\color{#d91a1a}-2.29\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0345ms 0.5017ms 1.9934 KOps/s 1.9214 KOps/s $\color{#35bf28}+3.74\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.3141ms 5.9352ms 168.4856 Ops/s 168.6162 Ops/s $\color{#d91a1a}-0.08\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.8861ms 0.3799ms 2.6325 KOps/s 2.5777 KOps/s $\color{#35bf28}+2.13\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7475ms 0.3627ms 2.7573 KOps/s 3.0696 KOps/s $\textbf{\color{#d91a1a}-10.17\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.0597ms 5.8307ms 171.5069 Ops/s 170.4813 Ops/s $\color{#35bf28}+0.60\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.3953ms 0.3695ms 2.7064 KOps/s 3.0120 KOps/s $\textbf{\color{#d91a1a}-10.15\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5645ms 0.3472ms 2.8806 KOps/s 3.7288 KOps/s $\textbf{\color{#d91a1a}-22.75\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 10.1420ms 6.2714ms 159.4550 Ops/s 163.8416 Ops/s $\color{#d91a1a}-2.68\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.2555ms 0.5119ms 1.9534 KOps/s 1.8802 KOps/s $\color{#35bf28}+3.89\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0124ms 0.4935ms 2.0264 KOps/s 1.8524 KOps/s $\textbf{\color{#35bf28}+9.39\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.5815s 16.8763ms 59.2546 Ops/s 187.6359 Ops/s $\textbf{\color{#d91a1a}-68.42\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 11.2008ms 2.1051ms 475.0454 Ops/s 488.3540 Ops/s $\color{#d91a1a}-2.73\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.0444ms 1.0826ms 923.7197 Ops/s 817.1848 Ops/s $\textbf{\color{#35bf28}+13.04\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 8.5257ms 5.3366ms 187.3862 Ops/s 185.8003 Ops/s $\color{#35bf28}+0.85\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 6.6835ms 2.0149ms 496.3004 Ops/s 472.4569 Ops/s $\textbf{\color{#35bf28}+5.05\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 8.8478ms 1.2738ms 785.0789 Ops/s 820.9277 Ops/s $\color{#d91a1a}-4.37\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 8.6611ms 5.5141ms 181.3537 Ops/s 51.7315 Ops/s $\textbf{\color{#35bf28}+250.57\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 8.8539ms 2.2126ms 451.9545 Ops/s 512.6418 Ops/s $\textbf{\color{#d91a1a}-11.84\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 8.5053ms 1.3699ms 730.0019 Ops/s 962.4035 Ops/s $\textbf{\color{#d91a1a}-24.15\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 43.7256ms 42.3829ms 23.5944 Ops/s 23.5310 Ops/s $\color{#35bf28}+0.27\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 19.4291ms 17.7215ms 56.4286 Ops/s 55.7281 Ops/s $\color{#35bf28}+1.26\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 44.7552ms 43.3400ms 23.0734 Ops/s 22.9752 Ops/s $\color{#35bf28}+0.43\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 19.7207ms 17.9891ms 55.5893 Ops/s 54.9464 Ops/s $\color{#35bf28}+1.17\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 0.4416s 53.3998ms 18.7267 Ops/s 21.7428 Ops/s $\textbf{\color{#d91a1a}-13.87\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 20.7349ms 19.3664ms 51.6359 Ops/s 50.7294 Ops/s $\color{#35bf28}+1.79\%$

@vmoens vmoens force-pushed the fixes branch 4 times, most recently from 1cb8e6a to 7ec4110 Compare November 13, 2025 21:37
@vmoens vmoens changed the title [Test] Fix flaky tests [Major] major refactoring of collectors Dec 1, 2025
@vmoens vmoens added bug Something isn't working enhancement New feature or request major major refactoring in the code base Refactoring Refactoring of an existing feature labels Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request major major refactoring in the code base Refactoring Refactoring of an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens